Add BinaryContent.from_path convenience method
#3482
Conversation
| if media_type is None: | ||
| media_type = 'application/octet-stream' | ||
|
|
||
| binary_content = BinaryContent(data=path.read_bytes(), media_type=media_type) |
There was a problem hiding this comment.
Why not on BinaryContent? :)
There was a problem hiding this comment.
you mean the default?
There was a problem hiding this comment.
@dsfaccini I meant that read_path was intended to be a method on BinaryContent, not FilePart, so I'm curious why you went the other way
There was a problem hiding this comment.
damn, that wasn't an active decision, honestly I just mixed up which class the method was supposed to go on, and I think my brain just though it made more sense on the FilePart (i.e. FilePart.from_path instead of BinaryContent.from_path)
I'll fix it now
There was a problem hiding this comment.
this is fixed now
DouweM
changed the title
FilePart.from_pathBinaryContent.from_path convenience method
| if media_type is None: | ||
| media_type = 'application/octet-stream' | ||
|
|
||
| return cls(data=path.read_bytes(), media_type=media_type) |
There was a problem hiding this comment.
Let's use narrow_type here to get an BinaryImage in case it's an image
| path = Path(path) | ||
| if not path.exists(): | ||
| raise FileNotFoundError(f'File not found: {path}') | ||
| media_type, _ = guess_type(path.as_posix()) |
There was a problem hiding this comment.
What do we need the as_posix for?
There was a problem hiding this comment.
thought I had a linter error from the pathlib.Path type, probably was something else
tests/test_messages.py
Outdated
| ) | ||
|
|
||
|
|
||
| def test_file_part_from_path(tmp_path: Path): |
There was a problem hiding this comment.
| def test_file_part_from_path(tmp_path: Path): | |
| def test_binary_content_from_path(tmp_path: Path): |
Co-authored-by: Douwe Maan <[email protected]>
2 participants
Replaces #3154